Sternenlabor/WLED
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Improve OTA release checking with scoring-based candidate selection

Browse Source 
Co-authored-by: netmindz <442066+netmindz@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-09-14 12:55:18 +00:00
parent caf3d900fd
commit fb077ecadc
1 changed files with 32 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
wled00/ota_release_check.cpp
View File

@@ -40,10 +40,14 @@ static bool isValidReleaseNameFormat(const char* name, size_t len) {
}
/**
* Extract release name by searching for null-terminated strings that look like release names
* Extract release name by searching for any reasonable string that could be a release name
* This method is very permissive to handle custom builds and unknown release formats
*/
static bool extractByGenericStringSearch(const uint8_t* data, size_t dataSize, char* extractedRelease) {
// Search for null-terminated strings that could be release names
char bestCandidate[64] = "";
int bestScore = -1;
for (size_t i = 0; i < dataSize - 4; i++) {
// Look for potential start of a string (printable character)
if (isalpha(data[i])) {
@@ -60,16 +64,28 @@ static bool extractByGenericStringSearch(const uint8_t* data, size_t dataSize, c
strncpy(candidate, (const char*)(data + i), len);
candidate[len] = '\0';
// Check if this looks like a valid release name
// Check if this looks like a valid release name format
if (isValidReleaseNameFormat(candidate, len)) {
// Additional heuristics: common WLED release name patterns
if (strstr(candidate, "ESP") != NULL || // Contains ESP
strstr(candidate, "WLED") != NULL || // Contains WLED
strstr(candidate, "Custom") != NULL) { // Custom build
strcpy(extractedRelease, candidate);
DEBUG_PRINTF_P(PSTR("Found release name by generic search: %s\n"), extractedRelease);
return true;
// Score candidates to find the most likely release name
int score = 0;
// High score for common patterns
if (strstr(candidate, "ESP") != NULL) score += 100;
if (strstr(candidate, "WLED") != NULL) score += 100;
if (strstr(candidate, "Custom") != NULL) score += 50;
if (strstr(candidate, "Build") != NULL) score += 30;
// Medium score for reasonable structure
if (len >= 5 && len <= 32) score += 20; // reasonable length
if (strchr(candidate, '_') != NULL) score += 10; // contains underscore (common in release names)
if (strchr(candidate, '-') != NULL) score += 10; // contains dash (common in release names)
// Basic score for any valid format
if (score == 0) score = 5; // Any valid format gets minimum score
if (score > bestScore) {
bestScore = score;
strcpy(bestCandidate, candidate);
}
}
}
@@ -77,6 +93,12 @@ static bool extractByGenericStringSearch(const uint8_t* data, size_t dataSize, c
}
}
if (bestScore > 0) {
strcpy(extractedRelease, bestCandidate);
DEBUG_PRINTF_P(PSTR("Found release name by generic search (score %d): %s\n"), bestScore, extractedRelease);
return true;
}
return false;
}