Code cleanups (#696)

* apply const in wrapper classes

* move NukiWrapper methods into Util class

* move NukiOpenerWrapper methods into Util class

* rename Util classes to Helper

* apply const to nuki network classes
This commit is contained in:
Jan-Ole Schümann
2025-09-28 19:06:59 +07:00
committed by GitHub
parent 5746625e11
commit be7c79ac8d
16 changed files with 1749 additions and 1958 deletions

View File

@@ -27,12 +27,12 @@ public:
void lockngo();
void lockngounlatch();
bool hasConnected();
bool isPinValid();
const bool hasConnected() const;
const bool isPinValid();
void setPin(const uint16_t pin);
void setUltraPin(const uint32_t pin);
uint16_t getPin();
uint32_t getUltraPin();
const uint16_t getPin();
const uint32_t getUltraPin();
void unpair();
void disableWatchdog();
@@ -41,12 +41,12 @@ public:
const bool isPaired() const;
const bool hasKeypad() const;
bool hasDoorSensor() const;
bool offConnected();
const bool offConnected();
const BLEAddress getBleAddress() const;
uint8_t restartController();
const uint8_t restartController() const;
std::string firmwareVersion() const;
std::string hardwareVersion() const;
const std::string firmwareVersion() const;
const std::string hardwareVersion() const;
void notify(Nuki::EventType eventType) override;
@@ -84,16 +84,6 @@ private:
void readConfig();
void readAdvancedConfig();
void printCommandResult(Nuki::CmdResult result);
NukiLock::LockAction lockActionToEnum(const char* str); // char array at least 14 characters
Nuki::AdvertisingMode advertisingModeToEnum(const char* str);
Nuki::TimeZoneId timeZoneToEnum(const char* str);
uint8_t fobActionToInt(const char *str);
NukiLock::ButtonPressAction buttonPressActionToEnum(const char* str);
Nuki::BatteryType batteryTypeToEnum(const char* str);
NukiLock::MotorSpeed motorSpeedToEnum(const char* str);
std::string _deviceName;
NukiDeviceId* _deviceId = nullptr;
NukiLock::NukiLock _nukiLock;