From 4303b0d877a049c14af153f438f4c2c63379db63 Mon Sep 17 00:00:00 2001
From: technyon <j.o.schuemann@gmx.de>
Date: Fri, 8 Apr 2022 22:01:31 +0200
Subject: [PATCH] hide characters for password fields

---
 WebCfgServer.cpp | 11 +++++++----
 WebCfgServer.h   |  2 +-
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/WebCfgServer.cpp b/WebCfgServer.cpp
index 71357c4..c42970e 100644
--- a/WebCfgServer.cpp
+++ b/WebCfgServer.cpp
@@ -216,7 +216,7 @@ void WebCfgServer::buildHtml(String& response)
     printInputField(response, "MQTTSERVER", "MQTT Broker", _preferences->getString(preference_mqtt_broker).c_str(), 100);
     printInputField(response, "MQTTPORT", "MQTT Broker port", _preferences->getInt(preference_mqtt_broker_port), 5);
     printInputField(response, "MQTTUSER", "MQTT User (# to clear)", _preferences->getString(preference_mqtt_user).c_str(), 30);
-    printInputField(response, "MQTTPASS", "MQTT Password", "*", 30);
+    printInputField(response, "MQTTPASS", "MQTT Password", "*", 30, true);
     printInputField(response, "MQTTPATH", "MQTT Path", _preferences->getString(preference_mqtt_path).c_str(), 180);
     printInputField(response, "LSTINT", "Query interval lock state (seconds)", _preferences->getInt(preference_query_interval_lockstate), 10);
     printInputField(response, "BATINT", "Query interval battery (seconds)", _preferences->getInt(preference_query_interval_battery), 10);
@@ -252,7 +252,7 @@ void WebCfgServer::buildCredHtml(String &response)
     response.concat("<h3>Credentials</h3>");
     response.concat("<table>");
     printInputField(response, "CREDUSER", "User (# to clear)", _preferences->getString(preference_cred_user).c_str(), 20);
-    printInputField(response, "CREDPASS", "Password", "*", 30);
+    printInputField(response, "CREDPASS", "Password", "*", 30, true);
     response.concat("</table>");
 
     response.concat("<br><INPUT TYPE=SUBMIT NAME=\"submit\" VALUE=\"Save\">");
@@ -284,7 +284,8 @@ void WebCfgServer::printInputField(String& response,
                                    const char *token,
                                    const char *description,
                                    const char *value,
-                                   size_t maxLength)
+                                   const size_t maxLength,
+                                   const bool isPassword)
 {
     char maxLengthStr[20];
 
@@ -295,7 +296,9 @@ void WebCfgServer::printInputField(String& response,
     response.concat(description);
     response.concat("</td>");
     response.concat("<td>");
-    response.concat(" <INPUT TYPE=TEXT VALUE=\"");
+    response.concat(" <INPUT TYPE=");
+    response.concat(isPassword ? "PASSWORD" : "TEXT");
+    response.concat(" VALUE=\"");
     response.concat(value);
     response.concat("\" NAME=\"");
     response.concat(token);
diff --git a/WebCfgServer.h b/WebCfgServer.h
index 4b94836..e24c4ae 100644
--- a/WebCfgServer.h
+++ b/WebCfgServer.h
@@ -32,7 +32,7 @@ private:
     void buildHtml(String& response);
     void buildCredHtml(String& response);
     void buildConfirmHtml(String& response);
-    void printInputField(String& response, const char* token, const char* description, const char* value, size_t maxLength);
+    void printInputField(String& response, const char* token, const char* description, const char* value, const size_t maxLength, const bool isPassword = false);
     void printInputField(String& response, const char* token, const char* description, const int value, size_t maxLength);
 
     void printParameter(String& response, const char* description, const char* value);