From 28da937c514696cde610b824e13ac1f2214d9b53 Mon Sep 17 00:00:00 2001
From: iranl <iranl@users.noreply.github.com>
Date: Tue, 11 Feb 2025 17:10:40 +0100
Subject: [PATCH] Always redact TOTP secret

---
 src/ImportExport.cpp  | 10 +++++++---
 src/PreferencesKeys.h |  3 ++-
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/ImportExport.cpp b/src/ImportExport.cpp
index a38e877..7d600b8 100644
--- a/src/ImportExport.cpp
+++ b/src/ImportExport.cpp
@@ -427,10 +427,14 @@ void ImportExport::exportNukiHubJson(JsonDocument &json, bool redacted, bool pai
         {
             continue;
         }
+        if(strcmp(key, preference_totp_secret) == 0)
+        {
+            continue;
+        }
         if(!redacted) if(std::find(redactedPrefs.begin(), redactedPrefs.end(), key) != redactedPrefs.end())
-            {
-                continue;
-            }
+        {
+            continue;
+        }
         if(!_preferences->isKey(key))
         {
             json[key] = "";
diff --git a/src/PreferencesKeys.h b/src/PreferencesKeys.h
index ac9b8d5..6658dff 100644
--- a/src/PreferencesKeys.h
+++ b/src/PreferencesKeys.h
@@ -540,7 +540,8 @@ private:
     std::vector<char*> _redact =
     {
         preference_mqtt_user, preference_mqtt_password, preference_cred_user, preference_cred_password, preference_nuki_id_lock, preference_nuki_id_opener, preference_wifi_pass,
-        preference_lock_gemini_pin, preference_cred_duo_host, preference_cred_duo_ikey, preference_cred_duo_skey, preference_cred_duo_user, preference_https_fqdn, preference_bypass_proxy
+        preference_lock_gemini_pin, preference_cred_duo_host, preference_cred_duo_ikey, preference_cred_duo_skey, preference_cred_duo_user, preference_bypass_proxy,
+        preference_totp_secret
     };
     std::vector<char*> _boolPrefs =
     {