Sternenlabor/WLED
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity
5,660 Commits 28 Branches 66 Tags
494b72c287f475543458da67d512f1fb25024bdb
Commit Graph

4036 Commits

Author SHA1 Message Date
Frank
566c5057f9 optimizations as per reviewer recommendations 
* removed unneeded initializations in blur() and blur2D()
* remove check for _t in progress()
* code readability: if (_t) --> if(isInTransition())
* add `isInTransition()` checks to currentBri() and currentMode()
* added missing `_transitionprogress = 0xFFFFU` in stopTransition()
 2025-01-19 07:35:46 +01:00
Frank
cd52d7bcf6 align some function declariations with their implementation 
This is purely a "clean code" thing, no impact on function -  it helps to avoid confusion when reading the code.

C++ allows declaration and implementation to use different variable names.
 2025-01-19 07:35:46 +01:00
Frank
ed3ec66d33 fix compile error 
"const" was missing in the function implementation
 2025-01-19 07:35:46 +01:00
Blaž Kristan
01c463c8e8 More tuning 
- replaced POD new/delete with malloc/free
- some more SEGLEN <= 1
- some gnu::pure
- more const attributes
- some static attributes
 2025-01-19 07:35:46 +01:00
Frank
872465df40 typo in comments 2025-01-19 07:35:46 +01:00
Frank
b6f74287d0 implement recommendations from reviewers 
* simplified transition bugfix
* removed cast same type
* isIp parameter changed to pass-by-reference, to avoid copy constructor
 2025-01-19 07:35:46 +01:00
Frank
013684b5ca making some parameters const, plus minor improvements 
* changed some parameters to "pointer to const", so compiler can better optimize code size and performance -  because data behind a const pointer will never be modified by the called function.
* made setPixelColor `const`

* fixed a few potentially uninitialized local vars (the may have random values if not initialized)

* avoid shadowing "state" in handleSerial()
* plus a few very minor improvements
 2025-01-19 07:35:46 +01:00
Frank
90c2955a71 avoid using keywords for variables: module, final 
these are reserved names and future compilers may reject them.
 2025-01-19 07:35:46 +01:00
Frank
7be868db12 bugfix: indexOf() returns -1 if string not found 
... so we must use `int` instead of `unsigned`
 2025-01-19 07:35:46 +01:00
Frank
703f84e5e1 code robustness improvements plus minor speedup 
* make  XY() and _setPixelColorXY_raw() const (minor speedup)
* segment is a struct not a class: friend class Segment --> friend struct Segment
* fix missing braces around two macros
* use non-throwing "new" where possible
* improve robustness of transition code
 2025-01-19 07:35:46 +01:00
netmindz
48f5099646 Merge pull request #4495 from netmindz/DMX-Input-AC 
Add Wired DMX Input support
 2025-01-17 19:31:25 +00:00
Kilrah
b9aeb19834 RF433 json usermod (#4234) 
* RF433 remote usermod

---------

Co-authored-by: Kilrah <kilrah@kilrah.xyz>
 2025-01-17 08:01:17 +01:00
netmindz
a4c3491f0c Merge pull request #4428 from blazoncek/waterfall-fix 
FX: Waterfall, Matripix & Dissolve fix
 2025-01-16 15:52:21 +00:00
netmindz
b2aac9f991 Merge pull request #4386 from DedeHai/ESPNow_glitchfix 
Fix for ESPNow remote causing output glitches
 2025-01-16 13:01:00 +00:00
Will Tatam
a582786655 Port over remaining WLEDMM part of DMX Input and adapt for AC 2025-01-16 12:48:36 +00:00
Will Tatam
9a6e91d3e5 DMX Input - reinstate loggers for connection state change 2025-01-16 12:22:51 +00:00
Will Tatam
fc4e7a2dee Swap DMX port to 1, persist user choice of port, validate port vs UART count 2025-01-16 12:22:32 +00:00
Will Tatam
a56014bb66 Hide DMX port as just confusing to users 2025-01-16 12:20:37 +00:00
Will Tatam
ebfc438bd4 Tweak DMX settings UI 2025-01-16 12:20:15 +00:00
Will Tatam
3996f02dea Revert "Rename WLED_ENABLE_DMX to WLED_ENABLE_DMX_OUTPUT" 
This reverts commit 7f9cc67518.
 2025-01-16 12:19:25 +00:00
Arne
d637524bfc chore: remove outdated comments 2025-01-16 12:16:50 +00:00
Arne
8570922dcc chore: adapt code style 2025-01-16 12:16:39 +00:00
Arne
6598265f9b make compile after rebase 2025-01-16 12:15:58 +00:00
Arne
8f398dfd08 Move dmx_input into its own task on core 0. 
This was necessary because otherwise it is not able to respond to rdm in time.
 2025-01-16 12:15:49 +00:00
Arne
68e9d701de Do no longer disable dmx_input when cache is disabled. 
No longer needed because missing ISR_ATTR have been added to esp_dmx.
 2025-01-16 12:15:37 +00:00
Arne
67e8a00b6d rename initDmx() -> initDmxOutput() 2025-01-16 12:11:21 +00:00
Arne
11b48bc374 rename handleDMX() handleDMXOutput() 2025-01-16 12:10:13 +00:00
Arne
fa80c62b28 rename dmx.cpp -> dmx_output.cpp 2025-01-16 12:06:10 +00:00
Arne
7f9cc67518 Rename WLED_ENABLE_DMX to WLED_ENABLE_DMX_OUTPUT 2025-01-16 12:05:40 +00:00
Arne
84eb6fd460 Add dmx input port to configuration 2025-01-16 11:47:48 +00:00
Arne
2cc5a29b86 keep dmx rdm identify on if dmx disconnects. 
Some rdm testers disconnect after setting it.
 2025-01-16 11:42:35 +00:00
Arne
b178c08271 Support dmx rdm personality change 2025-01-16 11:42:16 +00:00
Arne
9a3b208ac5 comments and cleanup 2025-01-16 11:37:14 +00:00
Arne
2989155f05 handle rdm dmx address changes 2025-01-16 11:37:05 +00:00
Arne
50b56c64f5 extract creation of dmx config into own method 2025-01-16 11:36:58 +00:00
Arne
be3e331afb Monitor dmx personality and dmx start address for change and update rdm 2025-01-16 11:36:50 +00:00
Arne
9d8fdd0b20 extract test for rdm identify into own method 2025-01-16 11:36:44 +00:00
Arne
033c7abe62 add enable/disable methods for dmxInput 2025-01-16 11:36:36 +00:00
Arne
5525a21696 rename settings 2025-01-16 11:36:24 +00:00
Arne
aed03cd03b hack: disable dmx receiver while wifi is being activated 
This fixes a crash in the dmx receiver. The dmx receiver cannot work while cache is disabled. For some reason activating wifi disables the cache. In theory, the driver is placed in iram and should work, but it doesn't. This might be a bug in the driver.
 2025-01-16 11:35:04 +00:00
Arne
5a5661f136 handle dmx rdm identify 2025-01-16 11:32:49 +00:00
Arne
a3bcf92ea5 Turn dmx_into into class with state. 
This is much nicer to read and in the future more state will be added to support all the rdm stuff.
 2025-01-16 11:29:39 +00:00
Will Tatam
0ad31c90f6 fix merge error 2025-01-16 11:26:42 +00:00
Arne
789d68e80d Move globals to top of file and change scope to compile unit only. 
Some minor cleanup changes
 2025-01-16 11:21:52 +00:00
Arne
f06a1e8b49 Extract dmx_input from dmx.cpp into dmx_input.cpp. 
This greatly improves readability because it gets rid of most of the
ifdefs.
 2025-01-16 11:21:41 +00:00
Arne
a0ca243955 Move dmx_input pin allocations from wled.cpp to dmx.cpp 2025-01-16 11:20:19 +00:00
Arne
9e2268bd74 Adapt to new api of esp_dmx v3.1 2025-01-16 11:17:58 +00:00
Arne
702d085117 rename global dmx... variables to dmxInput... 
This is the first step in supporting both dmx input and dmx output on different pins.
 2025-01-16 11:16:39 +00:00
Damian Schneider
278d204d1c merge fix for Deep-Sleep UM 2025-01-15 20:36:53 +01:00
Damian Schneider
39b3e7e507 BUGFIX in oscillate FX (#4494) 
effect was changed from int to uint but it relied on negative numbers. fixed by checking overflow and a cast.
 2025-01-15 15:17:56 +01:00