Correction
Correction of the sliders in the `setEffectParameters()` function to eliminate the need to update the old tooltip span.
This commit is contained in:
		| @@ -231,32 +231,26 @@ | ||||
| 				<label id="filterPal" class="check fchkl">🎨 | ||||
| 					<input type="checkbox" data-flt="🎨" onchange="filterFx(this)"> | ||||
| 					<span class="checkmark" tooltip="Uses palette"></span> | ||||
| 					<span class="hide tooltiptext ttfirst">Uses palette</span> | ||||
| 				</label> | ||||
| 				<label id="filter0D" class="check fchkl hide">• | ||||
| 					<input type="checkbox" data-flt="•" onchange="filterFx(this)"> | ||||
| 					<span class="checkmark" tooltip="Single pixel"></span> | ||||
| 					<span class="hide tooltiptext">Single pixel</span> | ||||
| 				</label> | ||||
| 				<label id="filter1D" class="check fchkl">⋮ | ||||
| 					<input type="checkbox" data-flt="⋮" onchange="filterFx(this)"> | ||||
| 					<span class="checkmark" tooltip="1D"></span> | ||||
| 					<span class="hide tooltiptext">1D</span> | ||||
| 				</label> | ||||
| 				<label id="filter2D" class="check fchkl">▦ | ||||
| 					<input type="checkbox" data-flt="▦" onchange="filterFx(this)"> | ||||
| 					<span class="checkmark" tooltip="2D Matrix"></span> | ||||
| 					<span class="hide tooltiptext">2D</span> | ||||
| 				</label> | ||||
| 				<label id="filterVol" class="check fchkl">♪ | ||||
| 					<input type="checkbox" data-flt="♪" onchange="filterFx(this)"> | ||||
| 					<span class="checkmark" tooltip="Volume"></span> | ||||
| 					<span class="hide tooltiptext">Volume</span> | ||||
| 				</label> | ||||
| 				<label id="filterFreq" class="check fchkl">♫ | ||||
| 					<input type="checkbox" data-flt="♫" onchange="filterFx(this)"> | ||||
| 					<span class="checkmark" tooltip="Frequency"></span> | ||||
| 					<span class="hide tooltiptext ttlast">Frequency</span> | ||||
| 				</label> | ||||
| 			</div> | ||||
| 			<div id="slider0" class="slider"> | ||||
| @@ -266,43 +260,38 @@ | ||||
| 					<div class="sliderdisplay"></div> | ||||
| 				</div> | ||||
| 				<output class="sliderbubble"></output> | ||||
| 				<span id="sliderLabel0" class="hide tooltiptext">Effect speed</span> | ||||
| 			</div> | ||||
| 			<div id="slider1" class="slider"> | ||||
| 				<i class="icons slider-icon" onclick="tglLabels()"></i> | ||||
| 				<div class="sliderwrap il"> | ||||
| 					<input id="sliderIntensity" class="noslide" onchange="setIntensity()" oninput="updateTrail(this)" max="255" min="0" type="range" value="128" /> | ||||
| 					<input id="sliderIntensity" tooltip="Effect intensity" class="noslide" onchange="setIntensity()" oninput="updateTrail(this)" max="255" min="0" type="range" value="128" /> | ||||
| 					<div class="sliderdisplay"></div> | ||||
| 				</div> | ||||
| 				<output class="sliderbubble"></output> | ||||
| 				<span class="tooltiptext" id="sliderLabel1">Effect intensity</span> | ||||
| 			</div> | ||||
| 			<div id="slider2" class="slider hide"> | ||||
| 				<i class="icons slider-icon"></i> | ||||
| 				<div class="sliderwrap il"> | ||||
| 					<input id="sliderC1" class="noslide" onchange="setCustom(1)" oninput="updateTrail(this)" max="255" min="0" type="range" value="0" /> | ||||
| 					<input id="sliderC1" tooltip="Custom 1" class="noslide" onchange="setCustom(1)" oninput="updateTrail(this)" max="255" min="0" type="range" value="0" /> | ||||
| 					<div class="sliderdisplay"></div> | ||||
| 				</div> | ||||
| 				<output class="sliderbubble"></output> | ||||
| 				<span class="tooltiptext" id="sliderLabel2">Custom 1</span> | ||||
| 			</div> | ||||
| 			<div id="slider3" class="slider hide"> | ||||
| 				<i class="icons slider-icon"></i> | ||||
| 				<div class="sliderwrap il"> | ||||
| 					<input id="sliderC2" class="noslide" onchange="setCustom(2)" oninput="updateTrail(this)" max="255" min="0" type="range" value="0" /> | ||||
| 					<input id="sliderC2" tooltip="Custom 2" class="noslide" onchange="setCustom(2)" oninput="updateTrail(this)" max="255" min="0" type="range" value="0" /> | ||||
| 					<div class="sliderdisplay"></div> | ||||
| 				</div> | ||||
| 				<output class="sliderbubble"></output> | ||||
| 				<span class="tooltiptext" id="sliderLabel3">Custom 2</span> | ||||
| 			</div> | ||||
| 			<div id="slider4" class="slider hide"> | ||||
| 				<i class="icons slider-icon"></i> | ||||
| 				<div class="sliderwrap il"> | ||||
| 					<input id="sliderC3" class="noslide" onchange="setCustom(3)" oninput="updateTrail(this)" max="31" min="0" type="range" value="0" /> | ||||
| 					<input id="sliderC3" tooltip="Custom 3" class="noslide" onchange="setCustom(3)" oninput="updateTrail(this)" max="31" min="0" type="range" value="0" /> | ||||
| 					<div class="sliderdisplay"></div> | ||||
| 				</div> | ||||
| 				<output class="sliderbubble"></output> | ||||
| 				<span class="tooltiptext" id="sliderLabel4">Custom 3</span> | ||||
| 			</div> | ||||
| 			<div id="fxopt" class="option fade"> | ||||
| 				<label id="opt0" class="check ochkl hide"><i class="icons"></i><span class="tooltiptext" id="optLabel0">Check 1</span> | ||||
|   | ||||
| @@ -1505,13 +1505,8 @@ function setEffectParameters(idx) | ||||
| 	let nSliders = 5; | ||||
| 	for (let i=0; i<nSliders; i++) { | ||||
| 		var slider = gId("slider" + i); | ||||
| 		var label = gId("sliderLabel" + i); | ||||
| 		// if (not controlDefined and for AC speed or intensity and for SR all sliders) or slider has a value | ||||
| 		if ((!controlDefined && i < ((idx<128)?2:nSliders)) || (slOnOff.length>i && slOnOff[i] != "")) { | ||||
| 			if (slOnOff.length>i && slOnOff[i]!="!") label.innerHTML = slOnOff[i]; | ||||
| 			else if (i==0)                           label.innerHTML = "Effect speed"; | ||||
| 			else if (i==1)                           label.innerHTML = "Effect intensity"; | ||||
| 			else                                     label.innerHTML = "Custom" + (i-1); | ||||
| 			slider.classList.remove('hide'); | ||||
| 		} else { | ||||
| 			slider.classList.add('hide'); | ||||
|   | ||||
							
								
								
									
										4083
									
								
								wled00/html_ui.h
									
									
									
									
									
								
							
							
						
						
									
										4083
									
								
								wled00/html_ui.h
									
									
									
									
									
								
							
										
											
												File diff suppressed because it is too large
												Load Diff
											
										
									
								
							
		Reference in New Issue
	
	Block a user
	 Alerson Jorge
					Alerson Jorge