From 2082b01a3cb98f322d4a756b8bd710bb1d03fa75 Mon Sep 17 00:00:00 2001 From: netmindz Date: Thu, 21 Aug 2025 08:53:11 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- usermods/udp_name_sync/udp_name_sync.cpp | 11 ++++++----- wled00/um_manager.cpp | 2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/usermods/udp_name_sync/udp_name_sync.cpp b/usermods/udp_name_sync/udp_name_sync.cpp index d926e1b67..cd279386a 100644 --- a/usermods/udp_name_sync/udp_name_sync.cpp +++ b/usermods/udp_name_sync/udp_name_sync.cpp @@ -45,15 +45,16 @@ class UdpNameSync : public Usermod { return; } - if (0 == strcmp(mainseg.name, segmentName)) return; //same name, do nothing + const char* curName = mainseg.name ? mainseg.name : ""; + if (strcmp(curName, segmentName) == 0) return; // same name, do nothing notifierUdp.beginPacket(broadcastIp, udpPort); DEBUG_PRINT(F("UdpNameSync: saving segment name ")); DEBUG_PRINTLN(mainseg.name); - byte length = strlen(mainseg.name); - strlcpy(segmentName, mainseg.name, length+1); - strlcpy((char *)&udpOut[1], segmentName, length+1); - notifierUdp.write(udpOut, length + 2); + size_t length = strlen(mainseg.name); + strlcpy(segmentName, mainseg.name, sizeof(segmentName)); + strlcpy((char *)&udpOut[1], segmentName, sizeof(udpOut) - 1); // leave room for header byte + notifierUdp.write(udpOut, 2 + strnlen((char *)&udpOut[1], sizeof(udpOut) - 1)); notifierUdp.endPacket(); DEBUG_PRINT(F("UdpNameSync: Sent segment name : ")); DEBUG_PRINTLN(segmentName); diff --git a/wled00/um_manager.cpp b/wled00/um_manager.cpp index 483fdc687..647757ad6 100644 --- a/wled00/um_manager.cpp +++ b/wled00/um_manager.cpp @@ -68,7 +68,7 @@ bool UsermodManager::onEspNowMessage(uint8_t* sender, uint8_t* payload, uint8_t return false; } #endif -bool UsermodManager::onUdpPacket(uint8_t* payload, uint8_t len) { +bool UsermodManager::onUdpPacket(uint8_t* payload, size_t len) { for (auto mod = _usermod_table_begin; mod < _usermod_table_end; ++mod) if ((*mod)->onUdpPacket(payload, len)) return true; return false; }